Add configurable HTTP polling interval for block monitoring by GabrielMartinezRodriguez · Pull Request #362 · HappyChainDevs/happychain

GabrielMartinezRodriguez · 2025-01-22T11:32:48Z

Linked Issues

closes https://linear.app/happychain/issue/HAPPY-303/if-the-rpc-provider-is-http-configure-the-polling-interval-to-avoid

Description

Adds configurable HTTP polling interval for block monitoring based on block time. When using HTTP transport, the system now polls for new blocks at an interval that is a fraction of the block time (defaulting to 1/8th)

Toggle Checklist

Checklist

Basics

B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
B2. This PR is not so big that it should be split & addresses only one concern.
B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments (e.g. local,
testnet, mainnet, standalone wallet, ...).
C3. I have manually tested my changes & connected features.
C4. I have performed a thorough self-review of my code after submitting the PR,
and have updated the code & comments accordingly.

Architecture & Documentation

D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
comments.
D3. If appropriate, the general architecture of the code is documented in a code comment or
in a Markdown document.

cloudflare-workers-and-pages · 2025-01-22T11:32:50Z

Deploying happychain with Cloudflare Pages

Latest commit:	`991bf7f`
Status:	✅ Deploy successful!
Preview URL:	https://a598b157.happychain.pages.dev
Branch Preview URL:	https://gabriel-txm-http-polling-int.happychain.pages.dev

View logs

GabrielMartinezRodriguez · 2025-01-22T11:33:13Z

Deploy randomness service #416 : 2 dependent PRs (#434 , #441 )
Add config contract #404
Randomness service: Improve performance and reliability #372
Add transaction submission failure hook and error handling #366
Increase default RPC timeout to 2000ms #365
Add configurable HTTP polling interval for block monitoring #362 👈 (View in Graphite)
Force initialization before using the TXM #361
Script to monitor randomness service #325
Script to easily launch the randomness service locally #324
Submit drand numbers #318
Random oracle contracts #307
Only prune finalized randomness entries #305
Add NewBlock hook #304
Refactors the randomness service to be able to process pending commitments #303
Add SQLite persistence to randomness service #300
Txm no longer receives Viem objects #298 : 1 other dependent PR (#299 )
Add flush mechanism #289 : 1 other dependent PR (#297 )
Allow run multiple txm simultaneously within the same service #285
Added docs for txm #272
Mutex in tx monitor #264
Purge transactions #232
Txm hooks #229
Use kysely instead of mikro-orm #250
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

linear · 2025-01-22T15:10:11Z

HAPPY-303 If the RPC provider is HTTP, configure the polling interval to avoid missing blocks.

not-reed · 2025-01-23T21:22:29Z

packages/transaction-manager/lib/TransactionManager.ts

    public readonly blockTime: bigint
    public readonly finalizedTransactionPurgeTime: number
+    public readonly pollingInterval: number
+    public readonly transportProtocol: "http" | "websocket"


feels odd to me to have 'http' and 'websocket' instead of 'ws'

also not sure if its an issue for you here or not (i think not?) but do you want tls variants?

Suggested change

public readonly transportProtocol: "http" | "websocket"

public readonly transportProtocol: "http" | "https" | "ws" | "wss"

the getUrlProtocol() function decodes "ws" or "wss" into either "http" or "websocket" and throws if its neither so its ok

aodhgan · 2025-02-05T01:09:28Z

packages/txm/lib/TransactionManager.ts

+
+        /**
+         * Specifies the polling interval in milliseconds.
+         * Defaults to 1/2 of the block time.


the PR description says the default 1/8th of the block time, but we will find an ideal default thru testing i think

…fraction

GabrielMartinezRodriguez mentioned this pull request Jan 22, 2025

Force initialization before using the TXM #361

Merged

10 tasks

GabrielMartinezRodriguez marked this pull request as ready for review January 22, 2025 11:37

GabrielMartinezRodriguez self-assigned this Jan 22, 2025

GabrielMartinezRodriguez added the reviewing-1 Ready for, or undergoing first-line review label Jan 22, 2025

GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch 2 times, most recently from 1f12879 to db559e2 Compare January 22, 2025 14:20

GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 3be8f45 to 6d998d9 Compare January 22, 2025 14:20

GabrielMartinezRodriguez mentioned this pull request Jan 22, 2025

Increase default RPC timeout to 2000ms #365

Merged

10 tasks

GabrielMartinezRodriguez mentioned this pull request Jan 22, 2025

Add transaction submission failure hook and error handling #366

Merged

10 tasks

GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch from db559e2 to ce40619 Compare January 23, 2025 10:37

GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from df46fd6 to f48f94c Compare January 23, 2025 10:37

GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch from ce40619 to 30792ba Compare January 23, 2025 14:44

GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from f48f94c to 0b937a8 Compare January 23, 2025 14:44

not-reed reviewed Jan 23, 2025

View reviewed changes

GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch from 30792ba to 9a55112 Compare January 31, 2025 14:44

GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 0b937a8 to 9fa6f10 Compare January 31, 2025 14:44

GabrielMartinezRodriguez mentioned this pull request Feb 3, 2025

Add config contract #404

Merged

10 tasks

GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch from 9a55112 to 5aee502 Compare February 3, 2025 12:40

GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 9fa6f10 to 9cee1b9 Compare February 3, 2025 12:40

GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch from 5aee502 to 7459249 Compare February 3, 2025 13:14

GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 9cee1b9 to 61a2966 Compare February 3, 2025 13:14

GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch from 7459249 to f8fd7af Compare February 4, 2025 13:51

GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 61a2966 to 6655ac3 Compare February 4, 2025 13:51

aodhgan reviewed Feb 5, 2025

View reviewed changes

aodhgan approved these changes Feb 5, 2025

View reviewed changes

aodhgan added reviewing-2 Ready for, or undergoing final review and removed reviewing-1 Ready for, or undergoing first-line review labels Feb 5, 2025

GabrielMartinezRodriguez added 2 commits February 5, 2025 15:01

fix(txm): configure polling interval if the rpc protocol is http

23caa0a

chore(txm): use an absolute polling interval instead of a block time …

991bf7f

…fraction

GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch from f8fd7af to 28a3351 Compare February 5, 2025 14:03

GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 6655ac3 to 991bf7f Compare February 5, 2025 14:03

GabrielMartinezRodriguez mentioned this pull request Feb 5, 2025

Deploy randomness service #416

Merged

10 tasks

aodhgan merged commit 19b3996 into gabriel/txm-force-initialization Feb 5, 2025
1 of 2 checks passed

aodhgan deleted the gabriel/txm-http-polling-interval branch February 5, 2025 16:07

This was referenced Feb 11, 2025

Added Interrupted status to transaction entity #434

Merged

debug #435

Closed

Implemented block inactivity timeout #441

Merged

GabrielMartinezRodriguez mentioned this pull request Feb 25, 2025

Fix: random() reverts once every 3 blocks #458

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add configurable HTTP polling interval for block monitoring#362

Add configurable HTTP polling interval for block monitoring#362
aodhgan merged 2 commits intogabriel/txm-force-initializationfrom
gabriel/txm-http-polling-interval

GabrielMartinezRodriguez commented Jan 22, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

GabrielMartinezRodriguez commented Jan 22, 2025 •

edited

Loading

Uh oh!

linear bot commented Jan 22, 2025

Uh oh!

not-reed Jan 23, 2025

Uh oh!

aodhgan Feb 5, 2025

Uh oh!

aodhgan Feb 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public readonly transportProtocol: "http" \| "websocket"
	public readonly transportProtocol: "http" \| "https" \| "ws" \| "wss"

Conversation

GabrielMartinezRodriguez commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked Issues

Description

Checklist

Basics

Correctness

Architecture & Documentation

Uh oh!

cloudflare-workers-and-pages bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying happychain with Cloudflare Pages

Uh oh!

GabrielMartinezRodriguez commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Jan 22, 2025

Uh oh!

not-reed Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

aodhgan Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

aodhgan Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GabrielMartinezRodriguez commented Jan 22, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

GabrielMartinezRodriguez commented Jan 22, 2025 •

edited

Loading

aodhgan Feb 5, 2025 •

edited

Loading